You can remove // start session if needed comment from all 3 methods, because it's already present in start method.

this comment is useless. The code is clear enough (and the phpdoc already says it too)

technically, these actions are not defined as supported before visiting (see the phpdoc of start)

But @peterrehm is using them and they work perfectly. Otherwise there is no way to open window initially with given size so that upon page visiting we won't be resizing it again.

Updated the list of Methods i the phpdoc. Is this what you meant?

this test must not be removed

I removed the test as I added the tests for the start() method.
As start() is tested for both options I thought it is enough to test just that start()
is called in e.g. the visit method.

well, the test you kept describes the wrong interaction with the driver (it does not describe the usage of isStarted.

and I would keep the test ensuring we can visit without starting, as the test does not need to know that the code is calling $this->start() internally rather than directly calling the driver.

But the test ensures that start is called:

    public function testVisit()
    {
        $this->driver
            ->expects($this->once())
            ->method('start');

        $this->driver
            ->expects($this->once())
            ->method('visit')
            ->with($url = 'some_url');

        $this->session->visit($url);
    }

The test with isStarted is not contained in testStartWithoutRunningSession and testStartWithRunningSession as the logic is moved to the start method.

But when you call $this->visit, the isStarted method of the driver is still called. So your description of the interaction is incomplete (and btw, because it is incomplete, isStarted would return null, not false).

PHPUnit mocks don't complain about incomplete interaction specifications, which is why your test is passing (and a reason why I actually prefer Prophecy, but I haven't converted the whole Mink testsuite to it)

But IMHO it doesn't matter in this case as we are finde if started() is called and afterwards the visit() method is called. Otherwise tests would need to be duplicated for the other autostart methods as well.

If you want I can add this in.

@stof , @peterrehm , any updates? This seem to be last change to be made before merging.

P.S.
Change actually needs to be made on #732 instead and this PR rebased on top of it.